[Orca-checkins] r277 - trunk/orca/lib/Orca

[Blair Zajac]

Author: blair
Date: Sun Jan 18 22:08:24 2004
New Revision: 277

Modified:
   trunk/orca/lib/Orca/Config.pm
Log:
* lib/Orca/Config.pm (check_config):
  When looping over groups and plots to verify, if there's an
  unrecoverable error for the group or plot, do not exit check_config
  immediately, instead skip that group or plot and just start checking
  the next one.  This is nicer to the user, as they'll get all errors
  listed at once instead of that annoying run once, fix errors, run
  again and find new errors.


Modified: trunk/orca/lib/Orca/Config.pm
==============================================================================
--- trunk/orca/lib/Orca/Config.pm	(original)
+++ trunk/orca/lib/Orca/Config.pm	Sun Jan 18 22:08:24 2004
@@ -496,11 +496,10 @@
       }
     }
 
-    # Exit now if there were any required options that were not set
-    # since use of then will cause uninitialized warnings.
-    if ($required_error) {
-      return $number_errors;
-    }
+    # Do not continue checking this group if there were any required
+    # options that were not set since use of then will cause
+    # uninitialized warnings from Perl later on.
+    next if $required_error;
 
     # Set any optional group parameters to '' if it isn't defined in
     # the configuration file.
@@ -695,11 +694,10 @@
       }
     }
 
-    # Exit now if there were any required options that were not set
-    # since use of then will cause uninitialized warnings.
-    if ($required_error) {
-      return $number_errors;
-    }
+    # Do not continue checking this plot if there were any required
+    # options that were not set since use of then will cause
+    # uninitialized warnings from Perl later on.
+    next if $required_error;
 
     # Create an array for each plot that will have a list of images that
     # were generated from this plot.