[Orca-dev] Re: [Orca-users] re: more info: dead zone on all graphs at same time

[Sean O'Neill]

At 11:53 AM 1/20/2003 -0800, Blair Zajac wrote:

>The real solution to the problem is to apply the following patch
>to include/live_rules.se in the SE distribution:
>
>
>--- include/live_rules.se.0     2002-07-16 18:02:54.000000000 -0700
>+++ include/live_rules.se       2002-12-28 21:39:26.000000000 -0800
>@@ -121,7 +121,7 @@
>  /* function to total up global per_cpu data into vmstat form */
>  p_vmstat vmglobal_total() {
>    int i;
>-  int total;
>+  double total;
>    p_vmstat pvm;
>
>    pvm = GLOBAL_pvm[0];
>@@ -151,8 +151,15 @@
>  #endif
>    }
>    total = pvm.user_time + pvm.system_time + pvm.wait_time + pvm.idle_time;
>-  if (total < 100) {
>-    pvm.idle_time += (100 - total);
>+  if (total < 100.0) {
>+    pvm.idle_time += (100.0 - total);
>+  }
>+
>+  /* Make sure that total is never greater than 100%.  Better less
>+   * than 100% than greater than 100%.  */
>+  total = pvm.user_time + pvm.system_time + pvm.wait_time + pvm.idle_time;
>+  if (total > 100.0) {
>+    pvm.idle_time -= (total - 100.0);
>    }
>    return pvm;
>  }

Blair, now that the Orca subversion repos has a lib/SE subdirectory 
structure, is there any reason why a patched version of live_rules.se can't 
be put into there and accessed the way orca_p_vmstat_class.se is now accessed ?

One comment on my changes to Orca (e.g. new metrics) - there may be some 
people out there who don't want the new metrics and just want good old Orca 
"as is".

Do you think further modification would be appropriate to maybe have a 
switch that indicates folks want "extended Orca stats".  To be honest, I 
haven't thought of upgrade issues with folks running the current Orca 
(0.27b3) who then upgrade to rev197+ (whatever version this ends up being).


--
........................................................
......... ..- -. .. -..- .-. ..- .-.. . ... ............
.-- .. -. -... .-.. --- .-- ... -.. .-. --- --- .-.. ...

Sean O'Neill