[Orca-dev] Re: group separator in data sets

[Blair Zajac]

Hans-Werner.Jouy at hamburglb.de wrote:
> 
> Hi Blair,
>  i am evaluating your orca on several systems, like sun, linux red hat and
> suse and aix.
> Server is linux based.
> On the main page available targets groups are separated, but data sets are
> not.
> 
> I added a small patch to enter a <tr> line between groups:
> around line 800 in orca.pl:
> 
>   # This sets the number of plot types to place into a single row in
>   # the main index.html.
>   $table_number_columns = 1;
>   @table_columns        = ();
> 
> +  my $group_old ="";
> 
>   # Go through all of the configured plots.
>   foreach my $config_plot (@config_plots) {
>     my $plot_creates = $config_plot->{creates};
>     next unless @$plot_creates;
> 
>     my $group_index = $config_plot->{source_index};
>     my $group_name  = $config_groups_names[$group_index];
> 
>     my $html_title_name = @config_groups > 1 ? " Group $group_name" : '';
> +    if ($group_old ne $group_name) {
> +      if (@config_groups > 1) {
> +          $index_html->print("</tr><tr bgcolor=#33cccc><th
> align=left>Group $group_name</th></tr><tr>\n");
> +    }
> +   $group_old = $group_name;
> +}
>     # Create an ordered list of images sorted on the legend name for
>     # each image.  Remember, each image represented here actually

Hi Hans,

[cc'ning Orca-dev mailing list].

I'm thinking it would be good to have each goup have a different
color instead of being hardwired to one additional color.  The
colors from @cc_default_colors in lib/Orca/Config.pm could be
used.  We could take the colors there use then as a background
color for each line of the data sets.

What do you think?  I'll take a patch for this and include it
in Orca.  Or better yet, if you want, get Subversion and you
can get write access to the Orca source tree.

> a second suggestion:
> is it possilbe to use different config files with a "include xxx.conf" in
> the main configuration?
> This makes sense when you use different collectors (i.e. for different
> architectures), a change in the
> collecting scripts then corresponds with the same include files. In this
> way different maintainers
> can modify independly from each other.

Good idea.  Patches welcome :)

> and a third (and last today)
> orca is a bit pricky about changing columns in a single machine. but
> sometimes I dont get all the columns,
> like nfs when no (auto-) mount is active. I have to fill all the missing
> info with zero inside the collecting script,,
> but it schould read "momentarily no data".

There's now a patch for the volitale columns, but not for data that
is missing.  This would need to happen to orcallator.se.  The data
it should output is not 0, but the letter 'U', so RRDtool knows to
ignore that data point.

See

http://www.orcaware.com/pipermail/orca-dev/2003-July/000389.html

> 
> thank you for your wonderful tools!

You're welcome!

Best,
Blair

-- 
Blair Zajac <blair at orcaware.com>
Plots of your system's performance - http://www.orcaware.com/orca/