FW: [Orca-dev] Re: One stray system with disk problems

[Jon Tankersley]

Hmm.....  I started looking at this a bit further....
>From the examples/disks.se note the following:
  for(i=0; i<GLOBAL_diskinfo_size; i++) {
    if (GLOBAL_disk_info[i].short_name == nil) {
      break;
    }
    if (strchr(GLOBAL_disk_info[i].short_name, ',') != nil) {
      continue;
    }

Maybe there are some logic issues with the structure in general.  This code
takes the same exit that I did.  It also ignores the comma delimted names
(sd0,a kind of thing).


-----Original Message-----
From: Blair Zajac [mailto:blair at orcaware.com] 
Sent: Sunday, July 04, 2004 1:06 AM
To: Jon Tankersley
Cc: orca-dev at orcaware.com
Subject: Re: FW: [Orca-dev] Re: One stray system with disk problems


Jon Tankersley wrote:

> 
> -----Original Message-----
> From: Jon Tankersley [mailto:jon.tankersley at eds.com]
> Sent: Saturday, July 03, 2004 11:33 PM
> To: 'Blair Zajac'; 'Paul Haldane'; 'Dmitry Berezin'
> Subject: RE: [Orca-dev] Re: One stray system with disk problems
> 
> 
> I think I found it...
> It is a bit nasty and I don't know why it happens, but...
> In orcallator.se 1.36 and in (1.37) there is a section of code...  It 
> doesn't check to see if GLOBAL_disk_info[j].short_name is nil or not.  
> It is, so the strcpy dies.
>       for (j=0; j<MAX_RAWDISKS; ++j) {
>         strcpy(short_name, GLOBAL_disk_info[j].short_name);
> 
> I just put an if in place before the strcpy:
>         if (GLOBAL_disk_info[j].short_name == nil) { break; }

This is good to know how to patch the symptom of the problem, but we need to

figure out what short_name is nil in the first place and fix the root cause.

Best,
Blair
-- 
Blair Zajac <blair at orcaware.com>
Plots of your system's performance - http://www.orcaware.com/orca/