[Orca-dev] SourceFile.pm:add_plots error?

[Blair Zajac]

Podhorodecki, Michael wrote:

> I believe that there is an error in SourceFile.pm:add_plots() for case 
> 2, "Regular expression match in the first data with additional datas".
> 
> The regular expression substitution is occurring not just for the new 
> plot data but is also being applied against previously processed plots 
> via the 'creates' hash key.
> 
> I was running orca-0.27 and procallator on Redhat 9 and everything was 
> working well until I added a host with a second disk, After which the 
> Orca process promptly grew to 400 MBytes in size and exited with an 
> "internal error: eval ...". Trying the development snapshot 
> "orca-snapshot-r323" still resulted in the same crash.
> 
> The clue was that the eval output had text between round brackets "()" 
> replaced with the name of the second disk drive "c0d1". Case 2 generates 
> a new copy of an existing plot for second and subsequent matches of the 
> re thus the 'creates' hash key is not null at this time.
> 
> As a quick check I simply deleted the 'creates' hash key before applying 
> the re on the plot data (line 948 appears to recreate the "creates" key 
> for new plots). A context diff is attached. For my hosts and data orca 
> is now running with no errors and I get plots for both "c0d0" and "c1d1".
> 
> The proper fix is probably to just copy the code in deep_clone_plot() 
> which saves the "creates" key before it is deleted and restores it 
> afterwards.

Michael,

Thanks.  A similar fix went in as revision 331.

> However I don't understand the intent of having a history of all plot 
> data created in this run attached to each plot rather than just that for 
> the current plot? Seems dangerous to me and an invitation to n^2 behaviour.

I'll have to take a look at this later.

Best,
Blair

-- 
Blair Zajac <blair at orcaware.com>
Plots of your system's performance - http://www.orcaware.com/orca/