[Orca-dev] orcallator.se dumps core in raw_disk_map

[Dagobert Michelsen]

Hi,

I just ran into the announced coredump at raw_disk_map in
orcallatot.se at line #603. The following patch did the trick:

--- orcallator.se.orig	2006-09-25 12:27:00.990035000 +0200
+++ orcallator.se	2006-09-25 12:28:36.466840000 +0200
@@ -627,6 +627,9 @@
     if (strncmp(RAW_disk[i].short_name, "st", 2) != 0) {
       if (strncmp(RAW_disk[i].short_name, "fd", 2) != 0) {
         for (j=0; j<MAX_RAWDISKS; ++j) {
+          if( GLOBAL_disk_info[j].short_name == nil ) {
+            break;
+          }
           strcpy(short_name, GLOBAL_disk_info[j].short_name);
           if (j > 0) {
             if (strncmp(first_name, short_name, first_len) == 0) {

Any idea why this happens? Interestingly I ran into a similar
coredump at zoom.se from the SE Toolkit which was fixed with
the following patch:

--- diskinfo.se	2006-09-25 10:37:16.192880000 +0200
+++ diskinfo.se.patch	2006-09-25 10:34:52.570554000 +0200
@@ -212,6 +212,10 @@
         GLOBAL_diskinfo_size += 4;
         GLOBAL_disk_info = renew GLOBAL_disk_info[GLOBAL_diskinfo_size];
       }
+
+      if( ld != 0 ) {
+        break;
+      }
       dp = *((dirent_t *) ld);
 
       // skip . and ..


Best regards

  -- Dagobert

--
Dagobert Michelsen (Leiter IT)          Baltic Online Computer GmbH
Alter Markt 1-2,   24103 Kiel,    +49 431 54003-0  (Fon) -99  (Fax)
Flughafenstr. 52c, 22335 Hamburg, +49 40 53299-395 (Fon) -100 (Fax)
"Of course computer servers don't need thrust, since they generally
don't go anywhere."  -- Comment in TR on new HP server turbine fans