Re [Svnmerge] Noisy pychecker on svnmerge.py

[Madan U S]

On Thu, 06 Apr 2006 23:33:55 +0530, Blair Zajac <blair at orcaware.com> wrote:

> Anybody want to take a crack at cleaning some of these up:
>
> $ pychecker --version
> $ pychecker svnmerge.py
> svnmerge.py:85: Statement appears to have no effect
> svnmerge.py:87: (False) shadows builtin
> svnmerge.py:87: (True) shadows builtin
> svnmerge.py:225: Using is None, may not always work
> svnmerge.py:405: Using is not None, may not always work
> svnmerge.py:411: Using is not None, may not always work
> svnmerge.py:597: tempfile.mktemp is deprecated
> svnmerge.py:631: Using is not None, may not always work
> svnmerge.py:793: No global (opts) found
> svnmerge.py:814: Using is None, may not always work
> svnmerge.py:959: Parameter (branch_props) not used
> svnmerge.py:1114: Parameter (branch_props) not used
> svnmerge.py:1147: Parameter (branch_props) not used
> svnmerge.py:1218: Using is not None, may not always work
> svnmerge.py:1231: Using is None, may not always work
> svnmerge.py:1232: Using is not None, may not always work
> svnmerge.py:1239: Using is not None, may not always work
> svnmerge.py:1260: Local variable (command_table) shadows global defined  
> on line 1576
> svnmerge.py:1261: Local variable (global_opts) shadows global defined on  
> line 1476
> svnmerge.py:1262: Local variable (common_opts) shadows global defined on  
> line 1500
> svnmerge.py:1278: Using is not None, may not always work
> svnmerge.py:1290: Using is not None, may not always work
> svnmerge.py:1364: Using is None, may not always work
> svnmerge.py:1405: Using is not None, may not always work
> svnmerge.py:1414: Using is None, may not always work
> svnmerge.py:1423: Using is not None, may not always work
>
> I cleaned up a few today already, but I've got other work to do now :)

Okay... I see that the number has visibly reduced now. How should I make patches fixing these... as a single patch, or as individual fixes?

Regards,
Madan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: /pipermail/svnmerge/attachments/20060412/1a8742f1/attachment.htm