Re [Svnmerge] Noisy pychecker on svnmerge.py

Madan U S madan at collab.net
Wed Apr 12 04:49:02 PDT 2006


On Wed, 12 Apr 2006 17:11:42 +0530, Giovanni Bajo <rasky at develer.com> wrote:

> Madan U S <madan at collab.net> wrote:
>
>>> $ pychecker --version
>>> $ pychecker svnmerge.py
>>> svnmerge.py:85: Statement appears to have no effect
[snip]
>>> svnmerge.py:1423: Using is not None, may not always work
>>>
>>> I cleaned up a few today already, but I've got other work to do now :)
>>
>> Okay... I see that the number has visibly reduced now. How should I make
>> patches fixing these... as a single patch, or as individual fixes?
>
> Last time I checked, many were bogus ones. For instance, I'm opposed to
> avoid the "is [not] None" paradigm.

Well, now, I dont see a single "is [not] None" error from pychecker. Anyways, why were you oppposed to it?

I will start working on the rest... will send multiple fixes in every patch. I hope this is fine.

Regards,
Madan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: /pipermail/svnmerge/attachments/20060412/0e1d538b/attachment.htm 


More information about the Svnmerge mailing list