Re [Svnmerge] Noisy pychecker on svnmerge.py

[Madan U S]

On Wed, 12 Apr 2006 17:56:07 +0530, Madan U S <madan at collab.net> wrote:

> On Wed, 12 Apr 2006 17:24:28 +0530, Giovanni Bajo <rasky at develer.com>  
> wrote:
>
>> Madan U S <madan at collab.net> wrote:
[snip]
>> What are the other issues? I don't like patches to shut up warnings
>> caused
>> by bugs/imperfections in external tools. If the tools help finding out
>> real
>> bugs, that's fine, let's fix them. But I'm -1 on any patch that tries to
>> adjust code so to shut down non-issues
>
> Agree.
>
>> and/or change our code to follow
>> some
>> coding convention (like the "is None" issue) the tools unilaterally
>> decided
>> it's the Good One(TM).
>
> Okay... following up this mail, I will compile the list of errors from  
> pychecker and mention which ones I feel should be fixed. I will send a  
> patch once we have a consensus on which ones need to be fixed and which  
> ones need not be. would that be okay?
>

Currently, I see the following warnings when I run pychecker on svnmerge.py

madan at localhost /tmp/wc/trunk $ pychecker --version
0.8.14
madan at localhost /tmp/wc/trunk $ pychecker /home/madan/wc/trunk/contrib/client-side/svnmerge.py
Processing svnmerge...

Warnings...

/home/madan/wc/trunk/contrib/client-side/svnmerge.py:85: Statement appears to have no effect
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:87: (False) shadows builtin
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:87: (True) shadows builtin
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:597: tempfile.mktemp is deprecated
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:795: No global (opts) found
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:966: Parameter (branch_props) not used
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:1121: Parameter (branch_props) not used
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:1154: Parameter (branch_props) not used
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:1267: Local variable (command_table) shadows global defined on line 1583
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:1268: Local variable (global_opts) shadows global defined on line 1483
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:1269: Local variable (common_opts) shadows global defined on line 1507


Out of these... I feel the following definitely need cleaning up... (remove branch_props from the parameter list)
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:966: Parameter (branch_props) not used
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:1121: Parameter (branch_props) not used
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:1154: Parameter (branch_props) not used

And the following need no action now, but will have to go away as we work our way on removing global variables (arent we gonna do that?)
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:795: No global (opts) found
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:1267: Local variable (command_table) shadows global defined on line 1583
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:1268: Local variable (global_opts) shadows global defined on line 1483
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:1269: Local variable (common_opts) shadows global defined on line 1507

The following are bogus....
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:85: Statement appears to have no effect
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:87: (False) shadows builtin
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:87: (True) shadows builtin
/home/madan/wc/trunk/contrib/client-side/svnmerge.py:597: tempfile.mktemp is deprecated

Giovanni, do you agree with my statement above?

Regards,
Madan.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: /pipermail/svnmerge/attachments/20060412/8f12a30f/attachment.htm