[Svnmerge] [PATCH] Bidirectional merging patch for svnmerge.py

[Blair Zajac]

Raman Gupta wrote:
> @@ -330,6 +331,9 @@
>  
>      def __iter__(self):
>          return iter(self.sorted())
> +        
> +    def __len__(self):
> +        return len(self._revs.keys())

Hi Raman,

I'm working through the patch to see what to merge into svn.collab.net.

I'm not too fond of the 'len' function operating on a RevisionList object, as 
the name isn't too clear.  Before I looked at the code, I was wondering if the 
length is the difference between the minimum and the maximum revision, but see 
that it's the count of revisions.

I would prefer to use a name such as count for this.

Comments?

Also, out of curiosity, do you have any code that uses this?  It doesn't appear 
that the bidirectional patch uses this new code.

Regads,
Blair