[Svnmerge] [PATCH] Bidirectional patch take 2

Raman Gupta rocketraman at fastmail.fm
Thu Feb 23 19:48:27 PST 2006


Blair Zajac wrote:

Some very small nits:

> +    when doing bidirectional merging between branches).
> +    Return a tuple of three RevisionsSet's:
                                       ^
Extra s -------------------------------+

> +    log_opts = '--quiet -r%s:%s "%s"' % (begin, end, url)
> +    if opts["bidirectional"]:
> +        log_opts = '--verbose ' + log_opts
> +    lines = launchsvn('log %s' % log_opts)
                         ^      ^
Most of the program seems to use double-quotes, but I'm not sure if
there any applicable community standards here.

> +        report("checking for reflected changes in %s revision(s)"
> +               % len(potential_reflected_revs))

I know this was in my original patch but this should probably be %d
revisions(s).

Cheers,
Raman




More information about the Svnmerge mailing list