[Svnmerge] [PATCH] make avail and integrated accepts URLs asarguments
Madan U Sreenivasan
madan at collab.net
Mon May 15 07:04:31 PDT 2006
On Mon, 15 May 2006 13:38:30 +0530, Mattias Brändström
<thebrasse at brasse.org> wrote:
> Mattias Brändström wrote:
>> Ok. Here is my patch and a test case for it. I did not change the flag
>> to a string, I think it will be easy enough to change that if it is
>> needed in the future.
>> :.:: mattias
>>
>
> This would be the commit message:
>
> Commands avail and integrated now accepts an URL as their argument as
> well as a subversion working copy.
Wont this sound better:
Sub-commands avail and integrated now accept either URL or working-copy
path as argument.
> * contrib/client-side/svnmerge.py:
> (CommandOpts#__init__): Accepts an extra argument indicating if this
> command accepts an URL as argument. This argument is assigned to
> self.accepts_url.
>
> (CommandOpts#_add_builtins): When command help is added to the command
> table we need to also provide an "accepts url" flag in the tuple.
>
> (command_table): New flag added to the tuple describing the commands.
> This
> flag is set to True if the commans should accept a URL as argument.
nitpicks :
s/commans/command
s/should accept/accepts/
>
> (main): Change in validating the branch_dir. If cmd.accepts_url is
> true
> then a URL is also accepted as a branch_dir.
>
> * contrib/client-side/svnmerge_test.py:
> Added test case for this feature.
Pl. give the classname.testname of the new test.
Regards,
Madan.
More information about the Svnmerge
mailing list