[Svnmerge] [PATCH] fix remaining test failures on Windows

Hernan Martinez Foffani hernan.martinez at ecc.es
Tue Jul 31 09:30:22 PDT 2007


>>> I've attached an updated patch to bug #2813 to use regexps and
>>> os.linesep to get the commit log messages right.  It works on
>>> Linux, but that's probably a given.  Luke, do you mind testing it
>>> on Windows?
>>
>> Dustin, I've updated your patch based on my testing here.  The new
>> patch I've added to the bug passes the testsuite on my windows boxes
>> here.
>>
>>
http://subversion.tigris.org/nonav/issues/showattachment.cgi/689/fixWindowsL
ineTermFailures-2.patch
>
> I don't think that collapsing a sequence of \r or \n to a single \n is
> the right thing to do: it would destroy paragraph formatting.

I agree.

>
> Is a simple "message = message.replace("\r\n", "\n")" enough? If not,
> why?

With the .replace tests pass ok in Windows.

Regards,
-H.







More information about the Svnmerge mailing list