[Svnmerge] [patch] fix get_svninfo parsing -- ":", not ": "
Dustin J. Mitchell
dustin at zmanda.com
Wed Apr 9 10:57:24 PDT 2008
On Tue, Apr 8, 2008 at 6:30 PM, Daniel Colascione <danc at merrillpress.com> wrote:
> If an "svn info" field is empty, one might see a line like
> 'Last Changed Author:', which makes split(": ") choke.
>
> Index: svnmerge.py
> ===================================================================
> --- svnmerge.py (revision 2755)
> +++ svnmerge.py (working copy)
> @@ -778,7 +778,7 @@
> L = L.strip()
> if not L:
> continue
> - key, value = L.split(": ", 1)
> + key, value = L.split(":", 1)
> info[key] = value.strip()
> _cache_svninfo[target] = info
> return info
Thanks for the patch! Any chance you could produce a test case that
would trigger the old, incorrect behavior?
Dustin
--
Storage Software Engineer
http://www.zmanda.com
More information about the Svnmerge
mailing list