[Svnmerge] Fwd: [Issue 2869] multiple pathid formats

[Giovanni Bajo]

On mar, 2009-02-17 at 18:32 -0500, Dustin J. Mitchell wrote:
> On Tue, Feb 17, 2009 at 6:16 PM, Giovanni Bajo <rasky at develer.com> wrote:
> > Any specific reason why you skipped it? The idea is that the additional
> > argument fail_on_invalid shouldn't be necessary, nor playing with the
> > "Not a valid URL" message. It is probably sufficient to check the return
> > value.
> 
> Well, the "Not a valid URL" part is for backward compatibility, as I
> remember it.  The fail_on_invalid affects the behavior of get_svninfo
> -- whether to call error() or not.  Most uses of get_svninfo want to
> error() out on an invalid URL, but check_url does not. 

I don't see how this last sentence can be true. In the current code,
get_svninfo() never errors out. It's your patch that adds code to bail,
and turn it on by default. In fact, you then adjust most uses of
get_svninfo() to pass "false" to the function.

AFAICT, if you remove this argument, you won't need the "Not a valid
URL" part as well.
-- 
Giovanni Bajo
Develer S.r.l.
http://www.develer.com