[Orca-dev] [PATCH] r528/data_gatherers/aix/orca-aix-stat.pl.in

[Blair Zajac]

David Michaels wrote:
> 
> This is more like a rewrite / replacement than a patch.  There have been 
> enough changes that the patch is 50% longer than the original file.  
> I've retooled the script quite a bit, and have distributed it personally 
> to some users who've requested it on orca-users.  I suspect most AIX 
> Orca users are using my version of this script.  I think even Rajesh is 
> using it.
> 
> I've attached a copy of the script and, for completeness, a copy of the 
> patch.
> 
> Here's a summary of some of the changes I've made since Rajesh first 
> distributed the script to Orca two years ago.  The big rewrite in 2005 
> was not logged.

Hi Dragon,

Would you mind sending a 'diff -u' output to read, as this patch looks like a 
diff -c, which is harder to read.

How long has this version of the script been in production?

>   2006-04-06 - Added ^L page markers

The policy is not to have those in source code, as they make it harder to read 
and edit.

Would you be interested in doing some more cleanup of the script?  It's got some 
older Perl style that could use some work.

Examples include

open IN, "netstat -ni|";
while (<IN>) {


This should check the open result:

open IN, "netstat -ni|"
   or die "$0: unable to open pipe from netstat -ni: $!\n";
while (<IN>) {


chomp($HOST = `uname -n`);

This should use the

use Sys::Hostname;
$HOST = hostname;

And my should be used everywhere.

Regards,
Blair