[Orca-dev] [PATCH] r528/data_gatherers/aix/orca-aix-stat.pl.in

[David Michaels]

Blair Zajac wrote:
> Hi Dragon,
>
> Would you mind sending a 'diff -u' output to read, as this patch looks 
> like a diff -c, which is harder to read.

Certainly.  To follow.

> How long has this version of the script been in production?

Technically, it's been only about 3 weeks (since the most recent mods).  
Roughly 20 months since my first major tweaks (from Rajesh's version, 
originally seeded to the orca list back in 2004).  It does still have 
some residual issues that I continue to work on (midnight rollover 
oddness), but the logistics in it are improved from the 2004 version 
(one file for both TSM and non-TSM machines, configure @@ substitution 
points, etc).

I made some more tweaks very recently that I've been testing on a few 
servers -- I cleaned up how syscalls are tracked (they were cumulative 
before, despite the code -- the code has been corrected to make them 
differential).  I'll include them in the next email's diff.

>
>>   2006-04-06 - Added ^L page markers
>
> The policy is not to have those in source code, as they make it harder 
> to read and edit.

Oh!  I didn't have them originally.  I got that from "README.DEVELOPERS" 
in svn/repos/orca/trunk:

    We're using page breaks (the Ctrl-L character, ASCII 12) for section
    boundaries in both code and plaintext prose files.


> Would you be interested in doing some more cleanup of the script?  
> It's got some older Perl style that could use some work.

Certainly.  I'm actually somewhat of a Perl neophyte, if it wasn't 
already evident from my code.

> And my should be used everywhere.

Yeah, that's one weakness I was aware of already, just hadn't gotten 
around to cleaning up.  The others are new tips, though, thanks. :)  
(serves me right for learning Perl from a Sun Perl Coursebook from 2002!).

Thanks!
--Dragon nemo omnibus horis sapit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: /pipermail/orca-dev/attachments/20060424/dcc2d5a9/attachment.htm