[Svnmerge] Re: svn commit: r19626 - trunk/contrib/client-side

[Blair Zajac]

On May 12, 2006, at 11:33 AM, Giovanni Bajo wrote:

> Blair Zajac wrote:
>
>> I'm thinking instead of using regex's over the XML, which granted is
>> fast, a cleaner approach may be to use an XML parsing library.  I'm
>> thinking of xmltramp, which generates a nice tree of dictionaries and
>> lists using the XML, which then we could iterate over.
>>
>> http://www.aaronsw.com/2002/xmltramp/
>>
>> xmltramp has been around for a while, so it probably has support for
>> older versions of Python.
>
> The only issue is that of external dependencies. Do we want to  
> require a
> non-standard library to run svnmerge.py? Or are you proposing to  
> still keep
> the regexp code as a fallback? BTW, I'm -1 on replacing the current  
> regexp
> code with SAX/DOM-based parser, which would take 200 lines or  
> something.

I'm ok with using ElementTree, given that it's now the standard XML  
library.

And with this module, wouldn't the code to find the revisions then  
just be several lines, not 200?

Does ElementTree depend upon any other non-standard modules?

Blair

-- 
Blair Zajac, Ph.D.
<blair at orcaware.com>
Subversion training, consulting and support
http://www.orcaware.com/svn/