[Svnmerge] Re: svn commit: r19626 - trunk/contrib/client-side

[Giovanni Bajo]

Garrett Rooney <rooneg at electricjellyfish.net> wrote:

>> And with this module, wouldn't the code to find the revisions then
>> just be several lines, not 200?
>
> Would it be worthwhile to save the non-elementtree version of the code
> for use when elementtree isn't available?

Of course. The whole point is why we should bother maintaining two paths of
code, given that the regexp version does indeed work (bugs aside...). If we
keep it around, even if the elementtree version is more stable, we still have
to fix those bugs.

The only real improvement I'd see in using ElementTree is that it would allow
to parse the log message from a pipe (thanks to the iterparse API) instead of
having to load it all in memory. I think I had attempted something like this
before, but was forced to use generators and dropped it because of
compatibility issues. I'll revisit it.

> I'd hate to see most of our
> users all of a sudden have to go download an external module just to
> use svnmerge.py.

Sure.

>> Does ElementTree depend upon any other non-standard modules?
>
> I don't think so...


No, it doesn't.

Giovanni Bajo