[Svnmerge] [SPAM] Re: [PATCH] fix bugs and tests from r22788

[Dustin J. Mitchell]

On Sat, Jul 07, 2007 at 10:51:03PM +0200, Giovanni Bajo wrote:
> On 07/07/2007 21.53, Dustin J. Mitchell wrote:
> > On Sat, Jun 30, 2007 at 01:20:24PM -0600, lsuvkne at onemodel.org wrote:
> >> The problem is that r22788 is initializing to the wrong revision number.  If
> 
> I'm missing too much history to understand it fully. I have a main question: 
> was the "svnmerge.py init" behaviour changed? If not, why we need to update 
> the tests?

Basically, r22788 changed 'svnmerge.py init' behavior and did not change
the test cases accordingly.

Luke has pointed out that the change in r22788 was not correct from the
perspective of matching users' expectations, and has created a patch to
make the behavior match the expectations (and his great explanation was
of the expected behavior).

AIUI, the test changes included with Luke's patch make the existing
tests pass, but do not add additional tests to verify the new behavior.

I'm happy to commit this patch as it stands, and since Luke is working
on patches that are probably of higher value, I'll write some additional
tests for the new behavior and submit them to teh list for review.  I
won't commit Luke's patch immediately, so please speak up if you have
objections.

Dustin

-- 
        Dustin J. Mitchell
        Storage Software Engineer, Zmanda, Inc.
        http://www.zmanda.com/