[Svnmerge] [SPAM] Re: [PATCH] fix bugs and tests from r22788

Giovanni Bajo rasky at develer.com
Tue Jul 10 23:54:34 PDT 2007


On 08/07/2007 2.11, Dustin J. Mitchell wrote:

>>>> The problem is that r22788 is initializing to the wrong revision number.  If
>> I'm missing too much history to understand it fully. I have a main question: 
>> was the "svnmerge.py init" behaviour changed? If not, why we need to update 
>> the tests?
> 
> Basically, r22788 changed 'svnmerge.py init' behavior and did not change
> the test cases accordingly.
> 
> Luke has pointed out that the change in r22788 was not correct from the
> perspective of matching users' expectations, and has created a patch to
> make the behavior match the expectations (and his great explanation was
> of the expected behavior).
> 
> AIUI, the test changes included with Luke's patch make the existing
> tests pass, but do not add additional tests to verify the new behavior.
> 
> I'm happy to commit this patch as it stands, and since Luke is working
> on patches that are probably of higher value, I'll write some additional
> tests for the new behavior and submit them to teh list for review.  I
> won't commit Luke's patch immediately, so please speak up if you have
> objections.

Yes, there's something that eludes me in this whole thread. I might just be 
confused, but I would like to understand better the issue. Please give me a 
few more days to review it.
-- 
Giovanni Bajo




More information about the Svnmerge mailing list